Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

docs(website): fix broken link to blog #3758

Merged
merged 1 commit into from
Nov 16, 2022
Merged

docs(website): fix broken link to blog #3758

merged 1 commit into from
Nov 16, 2022

Conversation

iamnapo
Copy link
Contributor

@iamnapo iamnapo commented Nov 16, 2022

Currently, clicking "Blog" when in doc.rome.tools from mobile, results in 404. So I hard-coded the link like in

<li class="blog"><a href="https://rome.tools/blog/">Blog</a></li>

@iamnapo iamnapo requested a review from a team November 16, 2022 06:23
@netlify
Copy link

netlify bot commented Nov 16, 2022

Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d77b7f9
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/637481dd35e3310008f9e0a2
😎 Deploy Preview https://deploy-preview-3758--docs-rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MichaReiser
Copy link
Contributor

That seems strange. What browser do you use? Are the docs and playground links working?

@iamnapo
Copy link
Contributor Author

iamnapo commented Nov 16, 2022

Hello @MichaReiser,

While browsing docs.rome.tools, /docs will point to docs.rome.tools/blog, won’t it?

I tried in Chrome, Brave and Safari.

@MichaReiser
Copy link
Contributor

Hello @MichaReiser,

While browsing docs.rome.tools, /docs will point to docs.rome.tools/blog, won’t it?

I tried in Chrome, Brave and Safari.

You're right. Thank you!

@MichaReiser MichaReiser added the A-Website Area: website and documentation label Nov 16, 2022
@MichaReiser MichaReiser merged commit c1ccf87 into rome:main Nov 16, 2022
@iamnapo iamnapo deleted the website/sidebar-link-fix branch November 16, 2022 09:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Website Area: website and documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants