This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): improve exception control flow handling #3761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3654
This changes the analysis of exception control flow to stop at the first catch handler while visiting an exception branch instead of unwinding all the way to the function root.
Test Plan
I've added a new test case for check for regressions for the associated issue. I've also updated the
JsTryFinallyStatement
snapshot since the fix also improves the diagnostics emitted bynoUnreachable
in some cases.