Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_semantic): include binding for type parameters #3803

Merged
merged 2 commits into from
Nov 21, 2022
Merged

fix(rome_js_semantic): include binding for type parameters #3803

merged 2 commits into from
Nov 21, 2022

Conversation

95th
Copy link
Contributor

@95th 95th commented Nov 20, 2022 •
edited by ematipico
Loading

Summary

Fixes #3798

Test Plan

cargo test -p rome_js_semantic
cargo test -p rome_js_analyze -- no_undeclared_variables

@netlify
Copy link

netlify bot commented Nov 20, 2022 •
edited
Loading

✅ Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 08e1fd3
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/637adf4e84f9fb000868d4dc

@ematipico ematipico merged commit 9c2e949 into rome:main Nov 21, 2022
@95th 95th deleted the fix/3798 branch November 21, 2022 16:47
@castarco castarco mentioned this pull request Nov 23, 2022
Closed
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ematipico ematipico ematipico approved these changes

@MichaReiser MichaReiser MichaReiser approved these changes

@leops leops Awaiting requested review from leops

@xunilrj xunilrj Awaiting requested review from xunilrj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Rome complains about "undeclared variable" for generic type variables in Typescript
3 participants
@95th @ematipico @MichaReiser