This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_cli): Fix max diagnostic counts #3869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 26, 2022 13:07
This PR fixes the max diagnostics count for the linter. The issue was that `process_file` reports a `Success` if a file has no diagnostic even if the file has skipped diagnostics. This PR changes `process_file` to return a `Message` if a file has reported diagnostics or any skipped diagnostics.
Fix symlink tests
✅ Deploy Preview for docs-rometools canceled.
|
leops
approved these changes
Nov 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the max diagnostics count for the linter.
The issue was that
process_filereports aSuccessif a file has no diagnostic, even if the file has skipped diagnostics.This PR changes
process_fileto return aMessageif a file has reported diagnostics or any skipped diagnostics.This PR further fixes an issue with the symlink tests that produced different output on unix/macos because the length of the resolved temp directory differs (
/tmpvs/var/tmp.../), resulting in shorter or longer horizontal lines