This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_service): internal errors as diagnostics #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
requested review from
leops,
xunilrj,
MichaReiser and
a team
as code owners
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ematipico
force-pushed
the
feat/rome-error-diagnostic
branch
2 times, most recently
from
45f1fda
to
e0ee01e
Compare
leops
reviewed
Dec 2, 2022
| ) | ||
| } | ||
| } | ||
| RomeError::FormatError(err) => err.message(f), |
There was a problem hiding this comment.
For diagnostics that contain an error, it might be more readable to print a message here (like "the formatter encountered an error while formatting the file" as we do in the Display implementation) and return the inner error as the source for this diagnostic (but this may not be possible currently since the Error type does not implement AsRef<dyn Diagnostic>)
There was a problem hiding this comment.
I changed the message but, as you thought, the source could not be used
ematipico
force-pushed
the
feat/rome-error-diagnostic
branch
from
e0ee01e
to
d3e8048
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
ematipico
force-pushed
the
feat/rome-error-diagnostic
branch
3 times, most recently
from
0c0e6b4
to
150c6d3
Compare
ematipico
force-pushed
the
feat/rome-error-diagnostic
branch
from
150c6d3
to
d882a7c
Compare
leops
approved these changes
Dec 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the trait
Diagnosticto the enumRomeError. This change doesn't change the current logic of how the errors are printed to the console.List of the changes:
diagnostics.rs, and it seems a generic pattern we are adopting across the code baseinstahas been moved into the workspace, so we have one single version across the code baseConfigurationError, so more and better information can be printed using theDiagnostictraitmessage()anddescription()functions are a copy-paste from theDisplaytrait, and I intend to keep them this way. We can review the messaging once the transition is completed and we print these diagnostics in the CLIThese changes are safe and can be merged whenever.
Test Plan
I created new snapshots to show the look and file of the changes.
The current tests of the CLI should stay the same.