This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): add module and classes support for noRedundantUseStrict #3955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzbac
requested review from
leops,
xunilrj,
ematipico and
a team
as code owners
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
MichaReiser
reviewed
Dec 5, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
MichaReiser
reviewed
Dec 5, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
| if let Some(module_or_class) = JsModuleOrClass::cast_ref(&n) { | ||
| outer_most = Some(module_or_class.into()); |
There was a problem hiding this comment.
I'm undecided if we should break if we find a class because it doesn't matter if any outer node has a use strict directive .
There was a problem hiding this comment.
I'm not sure if I understand this correctly. Are you saying that the 'use strict' is scoped within the class, so the outer node would have its own 'use strict' directive?
MichaReiser
approved these changes
Dec 9, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
ematipico
approved these changes
Dec 9, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_redundant_use_strict.rs
Outdated
Show resolved
Hide resolved
…strict.rs Co-authored-by: Micha Reiser <micha@reiser.io>
MichaReiser
approved these changes
Dec 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding module and class support for noRedundantUseStrict rule to address #3901
Test Plan
All tests added as part of PR.
cargo testpassed