This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nissy-dev
requested review from
MichaReiser,
xunilrj,
ematipico and
a team
as code owners
December 5, 2022 13:57
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
nissy-dev
force-pushed
the
support-auto-accessor
branch
from
December 7, 2022 12:16
339e48f
to
fc7c8db
Compare
MichaReiser
reviewed
Dec 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very well done!
I only ask you to add two more tests and we should then be good for merging this PR.
nissy-dev
force-pushed
the
support-auto-accessor
branch
from
December 9, 2022 00:54
e5425d1
to
31a30c7
Compare
…ols into support-auto-accessor
MichaReiser
approved these changes
Dec 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #3904
This PR is implementation for Auto Accessors released in TS.4.9.
Test Plan
I added some parser tests and passed some prettier tests.