Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat: Support Auto Accessors #3956

Merged
merged 9 commits into from
Dec 15, 2022
Merged

Conversation

nissy-dev
Copy link
Contributor

@nissy-dev nissy-dev commented Dec 5, 2022

Summary

Fix #3904

This PR is implementation for Auto Accessors released in TS.4.9.

Test Plan

I added some parser tests and passed some prettier tests.

@netlify
Copy link

netlify bot commented Dec 5, 2022

Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit a5fdc33
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6394964535051d00093570e0

@nissy-dev nissy-dev changed the title Support Auto Accessor feat: Support Auto Accessor Dec 5, 2022
@nissy-dev nissy-dev changed the title feat: Support Auto Accessor feat: Support Auto Accessors Dec 5, 2022
@MichaReiser MichaReiser added this to the Next milestone Dec 5, 2022
@MichaReiser MichaReiser mentioned this pull request Dec 8, 2022
2 tasks
Copy link
Contributor

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done!

I only ask you to add two more tests and we should then be good for merging this PR.

crates/rome_js_parser/src/syntax/class.rs Show resolved Hide resolved
crates/rome_js_parser/src/lexer/mod.rs Outdated Show resolved Hide resolved
@MichaReiser MichaReiser merged commit ba48b16 into rome:main Dec 15, 2022
@nissy-dev nissy-dev deleted the support-auto-accessor branch January 8, 2023 00:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 TypeScript 4.9
2 participants