This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 659
feat(rome_js_analyzer): partial implementation for rule noNoninteractiveElementToInteractiveRole
#4007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ematipico
force-pushed
the
feat/no-non-interative-elements
branch
from
December 7, 2022 14:43
e1cbd12
to
bdd63f2
Compare
ematipico
changed the title
feat(rome_js_analyzer): rule
feat(rome_js_analyzer): partial implementation for rule Dec 12, 2022
noNoninteractiveElementToInteractiveRole
noNoninteractiveElementToInteractiveRole
ematipico
force-pushed
the
feat/no-non-interative-elements
branch
from
December 12, 2022 11:44
bdd63f2
to
247d6cb
Compare
MichaReiser
reviewed
Dec 12, 2022
.../rome_js_analyze/src/aria_analyzers/nursery/no_noninteractive_element_to_interactive_role.rs
Outdated
Show resolved
Hide resolved
ematipico
force-pushed
the
feat/no-non-interative-elements
branch
from
December 13, 2022 09:46
247d6cb
to
e52280e
Compare
leops
reviewed
Dec 16, 2022
.../rome_js_analyze/src/aria_analyzers/nursery/no_noninteractive_element_to_interactive_role.rs
Outdated
Show resolved
Hide resolved
ematipico
force-pushed
the
feat/no-non-interative-elements
branch
from
December 19, 2022 11:05
e52280e
to
a20ec7c
Compare
ematipico
force-pushed
the
feat/no-non-interative-elements
branch
from
December 19, 2022 12:52
a20ec7c
to
f67c267
Compare
@leops can I get a review here, please? I need this PR merged in order to continue works around other rules |
ematipico
force-pushed
the
feat/no-non-interative-elements
branch
from
December 20, 2022 13:37
f67c267
to
6061bfe
Compare
leops
approved these changes
Dec 20, 2022
ematipico
force-pushed
the
feat/no-non-interative-elements
branch
3 times, most recently
from
December 21, 2022 09:17
7f48f69
to
6e3bed1
Compare
ematipico
force-pushed
the
feat/no-non-interative-elements
branch
from
December 21, 2022 09:29
6e3bed1
to
14afb98
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Start implementing #3816
Closes #3950
In order to implement this rule, new metadata were necessary. This metadata describes some of the existing roles, by adding the "concepts".
Concepts are information that tells us how an HTML can be mapped via ARIA roles, for example:
Can be mapped with ARIA roles like this:
This kind of information will be needed for another rule.
Not only that, though. These metadata are also useful to identify whether some HTML elements are non-interactive and if some ARIA roles are interactive.
"widget"
in their list of rolesFor example,
h1
is NOT interactive because there's a role called"heading"
that contains it, and this role is not interactive - it doesn't contain"widget"
The implementation of the rule still lacks some logic that I need to figure out, so the rule is still under heavy development.
Test Plan
I added some test cases to make sure the rule works, but I plan to add more test cases once the implementation of the rule is correct.
The old rule had a bug, which I fixed in this version of the rule.