This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): noCommaOperator
#4019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conaclos
requested review from
leops,
ematipico,
xunilrj and
a team
as code owners
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Conaclos
changed the title
noSequences
|
Nice! Thanks. |
xunilrj
reviewed
Dec 9, 2022
xunilrj
reviewed
Dec 9, 2022
xunilrj
reviewed
Dec 9, 2022
leops
reviewed
Dec 12, 2022
There was a problem hiding this comment.
I personally think we should rename the rule to noCommaOperator since "sequence" is used internally as the name of the AST node but may not be clear to the end-user (this can be seen in the documentation for the ESLint rule using the name "comma operator" more prominently than the term "sequence")
MichaReiser
approved these changes
Dec 12, 2022
Conaclos
changed the title
noSequencesnoComaOperator
Conaclos
changed the title
noComaOperatornoCommaOperator
leops
approved these changes
Dec 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes: #3932
This implements ESlint's rule no-sequences.
In contrast to ESLint, we do not support the option
allowInParentheses(enabled by default in ESLint ; disabled in Rome).I am wondering whether we should rename the rule to
noComaOperator?Test Plan
Unit and doc tests included (copied from ESLint).