This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_cli): Add JS runtime and package manager information to rage
#4021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
MichaReiser
force-pushed
the
feat/add-node-to-rage
branch
from
9c374de
to
cc90db1
Compare
## Summary This PR extends the `rome rage` command to include the name and version of the JavaScript runtime that executed the `rome` wrapper script as well as the name and version of the package manager: ## Test Plan ``` ❯ npx rome rage CLI: Version: 0.0.0 Color support: true Platform: CPU Architecture: x86_64 OS: windows Environment: ROME_LOG_DIR: unset NO_COLOR: unset TERM: unset JS_RUNTIME_VERSION: "v16.13.2" JS_RUNTIME_RELEASE: "node" NODE_PACKAGE_MANAGER: "npm/8.3.0" ❯ yarn rome rage yarn run v1.22.19 $ C:\Users\Micha\git\rome-test\node_modules\.bin\rome rage CLI: Version: 0.0.0 Color support: true Platform: CPU Architecture: x86_64 OS: windows Environment: ROME_LOG_DIR: unset NO_COLOR: unset TERM: unset JS_RUNTIME_VERSION: "v16.13.2" JS_RUNTIME_RELEASE: "node" NODE_PACKAGE_MANAGER: "yarn/1.22.19" ❯ pnpm rome rage CLI: Version: 0.0.0 Color support: true Platform: CPU Architecture: x86_64 OS: windows Environment: ROME_LOG_DIR: unset NO_COLOR: unset TERM: unset JS_RUNTIME_VERSION: "v16.13.2" JS_RUNTIME_RELEASE: "node" NODE_PACKAGE_MANAGER: "pnpm/7.13.6" ```
MichaReiser
force-pushed
the
feat/add-node-to-rage
branch
from
cc90db1
to
145756d
Compare
xunilrj
approved these changes
Dec 9, 2022
ematipico
approved these changes
Dec 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the
rome ragecommand to include the name and version of the JavaScript runtime that executed theromewrapper script as well as the name and version of the package manager:Test Plan