This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyzer): rule useValidLang
#4045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3948
I added a new
AriaIso
struct that exposes some utility function to check if a country/language is valid.The diagnostics are different from the old rule. The old rules used to do a combination of
<LANGUAGE>-<COUNTRIES>
when given possible valid suggestions. Here I decided to keep it dumber and to just suggest the correct language when it's wrong, and then the correct countries if the country isn't correct.Test Plan
Added some test cast