This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyzer): rule useHtmlLang
#4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkldshv
requested review from
leops,
ematipico,
xunilrj and
a team
as code owners
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
|
In general rule works as expected but I feel some code can be simplified/refactored. I'd appreciate any suggestions! |
ematipico
reviewed
Dec 14, 2022
|
@ematipico Thanks for the review! I'll adjust code where necessary and push the changes. |
mrkldshv
commented
Dec 14, 2022
leops
reviewed
Dec 15, 2022
mrkldshv
force-pushed
the
feature/use-html-lang
branch
from
80af2e0
to
646cf7e
Compare
leops
approved these changes
Dec 20, 2022
Yeah, I think it makes sense. We created two rules because the eslint plugin has two rules, so we tried not to diverge too much. We can easily merge the two rules into one later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3944.
Test Plan
Run newly added tests.
Documentation