This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): noUnsafeOptionalChain, no-unsafe-optional-chaining #3985 #4081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denbezrukov
requested review from
leops,
ematipico,
xunilrj and
a team
as code owners
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
ematipico
reviewed
Dec 23, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_unsafe_optional_chaining.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_unsafe_optional_chaining.rs
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_unsafe_optional_chaining.rs
Show resolved
Hide resolved
denbezrukov
force-pushed
the
feature/no-unsafe-optional-chain-1
branch
from
eef31ac
to
e4689d6
Compare
denbezrukov
force-pushed
the
feature/no-unsafe-optional-chain-1
branch
3 times, most recently
from
eb89f2c
to
9ab1cd6
Compare
denbezrukov
requested review from
ematipico
and removed request for
xunilrj and
leops
ematipico
approved these changes
Feb 15, 2023
crates/rome_js_analyze/src/analyzers/nursery/no_unsafe_optional_chaining.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_unsafe_optional_chaining.rs
Outdated
Show resolved
Hide resolved
denbezrukov
force-pushed
the
feature/no-unsafe-optional-chain-1
branch
from
9ab1cd6
to
c75e616
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #3985
Original eslint rule has an option
disallowArithmeticOperatorsdecided to skip it for now.Eslint rule and current version have a different implementation:
It seems that the second version is more efficient because it skips nodes without option chaining.
Test Plan
Added test cases from eslint
cargo testDocumentation