Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_lsp): add link to LSP diagnostic #4099

Merged
merged 2 commits into from
Jan 1, 2023
Merged

Conversation

ematipico
Copy link
Contributor

Summary

This PR

Test Plan

Manually checked that the link is added:

Screenshot 2022-12-23 at 08 41 36

I updated the test suite too.

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@ematipico ematipico added A-LSP Area: language server protocol A-Editors Area: editors labels Dec 23, 2022
@ematipico ematipico added this to the Next milestone Dec 23, 2022
@ematipico ematipico requested a review from a team as a code owner December 23, 2022 08:59
@netlify
Copy link

netlify bot commented Dec 23, 2022

Deploy Preview for docs-rometools ready!

Name Link
🔨 Latest commit acc99d1
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/63a59288ab1a1c00080cad4f
😎 Deploy Preview https://deploy-preview-4099--docs-rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 48647 48647 0
Passed 47582 47582 0
Failed 1065 1065 0
Panics 0 0 0
Coverage 97.81% 97.81% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6093 6093 0
Passed 1754 1754 0
Failed 4339 4339 0
Panics 0 0 0
Coverage 28.79% 28.79% 0.00%

ts/babel

Test result main count This PR count Difference
Total 639 639 0
Passed 565 565 0
Failed 74 74 0
Panics 0 0 0
Coverage 88.42% 88.42% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16740 16740 0
Passed 12817 12817 0
Failed 3923 3923 0
Panics 0 0 0
Coverage 76.57% 76.57% 0.00%

@ematipico ematipico merged commit 0639ba4 into main Jan 1, 2023
@ematipico ematipico deleted the feat/diagnostic-link-lsp branch January 1, 2023 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Editors Area: editors A-LSP Area: language server protocol
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants