This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
chore: Update dependencies #4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
requested review from
leops,
xunilrj,
ematipico and
a team
as code owners
✅ Deploy Preview for docs-rometools canceled.
|
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
``` rome_rowan ================ Name Project Compat Latest Kind Platform ---- ------- ------ ------ ---- -------- hashbrown 0.12.3 --- 0.13.1 Normal --- memoffset 0.6.5 --- 0.8.0 Normal --- rome_js_analyze ================ Name Project Compat Latest Kind Platform ---- ------- ------ ------ ---- -------- retain_mut 0.1.9 --- 0.1.7 Normal --- roaring 0.9.0 --- 0.10.1 Normal --- xtask_bench ================ Name Project Compat Latest Kind Platform ---- ------- ------ ------ ---- -------- humansize 1.1.1 --- 2.1.2 Normal --- ```
MichaReiser
force-pushed
the
chore/update-dependencies
branch
from
63cd477
to
21163ca
Compare
|
The snapshots of the JS API hints that we have to release a new breaking version. Now we return undefined instead of null |
MichaReiser
force-pushed
the
chore/update-dependencies
branch
from
67cb45b
to
a03d459
Compare
I changed the serializer to serialize to |
MichaReiser
commented
Dec 30, 2022
| @@ -49,7 +49,7 @@ jobs: | |||
| uses: actions-rs/clippy-check@v1 | |||
| with: | |||
| token: ${{ secrets.GITHUB_TOKEN }} | |||
| args: --workspace --all-targets --all-features --verbose -- --deny warnings -W clippy::cargo -W clippy::dbg_macro -A clippy::cargo_common_metadata | |||
| args: --workspace --all-targets --all-features --verbose -- --deny warnings -W clippy::cargo -W clippy::dbg_macro -A clippy::cargo_common_metadata -A clippy::multiple_crate_versions | |||
There was a problem hiding this comment.
Our dependencies require conflicting hermit-abi versions. I haven't found a way to resolve the version conflict.
There was a problem hiding this comment.
Any chance to revert the dependencies that cause this issue, and wait that this issue is fixed upstream?
There was a problem hiding this comment.
For this specific package it's only an issue if someone tries to build Rome for the x86_64-unknown-hermit target, but it's unfortunate that we have to disable the rule entirely instead of being able to add an exception for a single package
|
!bench_analyzer |
Analyzer Benchmark Results |
|
!bench_formatter |
|
!bench_parser |
Parser Benchmark Results |
Formatter Benchmark Results |
|
This PR is stale because it has been open 14 days with no activity. |
ematipico
force-pushed
the
chore/update-dependencies
branch
from
ec93291
to
dddfbee
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates all outdated dependencies.
Major bumps:
Test Plan
cargo testDocumentation