This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 659
refactor(rome_js_parser): Inroduce TypeContext #4123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
🎉 Fixed (2):
ts/microsoft
|
!bench_parser |
Parser Benchmark Results
|
ematipico
approved these changes
Jan 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the state tracking if conditional types are allowed from the
ParserState
into a newTypeContext
explicitly passed as an argument to type parsing methods, similar to theExpressionContext
for parsing expressions.The advantage of an passing the context as an argument over an additional flag on the state is that it is easier to reason about the state of the parser and avoids accidental "leaking" of the conditional types when switching between parsing types and expressions (as it is the case when parsing the function parameters).
Test Plan
I verified that the fixed regressions are intentional.
Documentation