This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_lsp): add a replace_range method to Document
#4135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ematipico
approved these changes
Jan 4, 2023
ematipico
approved these changes
Jan 5, 2023
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR add a new
replace_rangemethod to theDocumentandLineIndexdata structures used internally in the Language Server to track the state of an open document. This new method allows the text of an existing document and its associated line index to be updated in place, instead of having to be recreated from scratch on every change. I also took the opportunity to remove the duplicate storage of the text in bothDocumentandLineIndex, the string is now only stored in the innermost structure (the line index).Test Plan
I've added a few manual test case for the new
replace_rangemethod onLineIndex, as well as an automated "property test" that checks the function works correctly over a diverse range of values using theproptestcrate.Documentation