Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(vscode): enable JSON formatting #4146

Merged
merged 10 commits into from
Jan 10, 2023

Conversation

ematipico
Copy link
Contributor

@ematipico ematipico commented Jan 10, 2023

Summary

This PR adds json to the list of activation events. With this PR, the extension will recognise JSON files are files that can b handled by the extension.

Test Plan

I locally built the extension and made sure that:

  • package.json is not formatted
  • any JSON file is formatted, using the configuration inside rome.json

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

Micha Reiser and others added 8 commits January 10, 2023 10:47
Signed-off-by: Micha Reiser <micha@famreiser.ch>
Signed-off-by: Micha Reiser <micha@famreiser.ch>
Co-authored-by: Superchupu <53496941+SuperchupuDev@users.noreply.github.com>
@ematipico ematipico requested a review from a team as a code owner January 10, 2023 10:50
@netlify
Copy link

netlify bot commented Jan 10, 2023

Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit 328115f
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/63bd6f2ef7d40a0008eaa750

@ematipico ematipico added E-VScode Editors: VSCode A-Editors Area: editors labels Jan 10, 2023
@ematipico ematipico added this to the Next milestone Jan 10, 2023
@ematipico ematipico requested a review from leops as a code owner January 10, 2023 13:16
@ematipico ematipico force-pushed the feature/enable-json-formatting-vscode branch from 387bbc5 to 9579440 Compare January 10, 2023 13:17
@ematipico ematipico force-pushed the feature/enable-json-formatting-vscode branch from 9579440 to 19a55aa Compare January 10, 2023 13:37
editors/vscode/package.json Outdated Show resolved Hide resolved
@ematipico ematipico merged commit 99ee725 into main Jan 10, 2023
@ematipico ematipico deleted the feature/enable-json-formatting-vscode branch January 10, 2023 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Editors Area: editors E-VScode Editors: VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants