-
Notifications
You must be signed in to change notification settings - Fork 659
feat(rome_cli): Add a new option --config-path to set the path to rome.json #4158
Conversation
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
b4b4ef2
to
2eda94a
Compare
2eda94a
to
680f251
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! I think we should rename the option, for example --config-path
. This would be in line with --file-path
@ematipico Yes, I like this idea. I renamed the option to --config-path and updated the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried running the CLI using windows like style paths? E.g. --config-path=..\foo\rome.json
Does it work?
The dot notation is covered by the DOS specification assert_eq!(Path::new("..\\..").join("rome.json"), PathBuf::from("..\\..\\rome.json")); |
@realtimetodie could you please tick the checkbox of |
@ematipico Yes, I will take care of the documentation. |
Adds a new option --config-path to set the filesystem path to the directory of the rome.json configuration file.
Example
The --config option appends a base path to the rome.json configuration file path
Error handling
If the user explicitly sets a path to the rome.json configuration file using the --config-path option and the file is not found, an error will be thrown.
Example
Error message