Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat: add react/no-danger-with-children lint rule #421

Merged
merged 2 commits into from
May 13, 2020
Merged

feat: add react/no-danger-with-children lint rule #421

merged 2 commits into from
May 13, 2020

Conversation

bitpshr
Copy link
Contributor

@bitpshr bitpshr commented May 13, 2020

This pull request implements the react/no-danger-with-children lint rule, disallowing the use of children with dangerouslySetInnerHTML.

References #341

@ooflorent
Copy link
Contributor

ooflorent commented May 13, 2020

There is a missing case: when children is set as a property.

@bitpshr
Copy link
Contributor Author

bitpshr commented May 13, 2020

Good catch @ooflorent. PR updated accordingly.

@sebmck sebmck merged commit 9e3b108 into rome:master May 13, 2020
@sebmck
Copy link
Contributor

sebmck commented May 13, 2020

Looks great, thank you so much!

@bitpshr bitpshr deleted the feat/react-no-danger-with-children branch May 14, 2020 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants