This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
Remove unsafe from rome_diagnostics::display::frame #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
ematipico
approved these changes
Feb 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
unsafeblocks in this module are unnecessary, so let’s remove them.Test Plan
The test suite segfaults for me (both with and without this change), so I’m relying on CI here. Clearly we’re misusing
unsafesomewhere, and we should removeunsafewherever possible. Although these particular uses ofunsafeare among the more innocuous ones, I figured they’re a good starting point.Documentation