This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_formatter): no comment reordeing in default clause #4255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a tentative fix for #4254 that is blocking #4234.
For now, the fix avoids comments reordering in default clauses and the reformat failure.
However, this makes a regression on prettier compatibility.
Indeed, the following code:
is formatted to:
// comment
should not be moved.Any help could be welcome!
Test Plan
Documentation
No change.