Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

website(docs): Enhance the documentation for the config-path option #4294

Merged
merged 2 commits into from
Mar 11, 2023

Conversation

realtimetodie
Copy link
Contributor

@realtimetodie realtimetodie commented Mar 10, 2023

Enhances the documentation for the new config-path option and defuses some strong wording (Warning -> Important).

Related

Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion, but I like your wording! Thank you!


> **Important**: when passing `--config-path`, the auto discovery of the `rome.json` configuration file is disabled.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something that I wanted to highlight, was also the fact that when this option is passed, Rome will abort if the configuration is not found. This is different from the default behaviour.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I highlighted the auto discovery feature in the introduction header of the configuration page too. Please take a lookm and I updated the introduction text so that it starts with talking about what configuration is first (Rome has a default configuration) and then mentions the rome.json configuration file in the second paragraph.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the wording to Important: ... primarily because using the --config-path option is not bad per-se (a warning is bad).

@ematipico ematipico merged commit 6e9adaa into rome:release/12.0.0 Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants