Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_lsp): pull diagnostics for rome.json #4296

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

ematipico
Copy link
Contributor

Summary

This PR adds a minor improvement to the LSP. When the workspace requests diagnostics for a JSON file, we check if the file being analyzed is a rome.json file and attempt to deserialize and return additional diagnostics.

While the schema is already valuable for the majority of the cases:

  • sometimes, people don't use the JSON schema, or they are not aware of it;
  • there are situations where we run specific validations;

Test Plan

I added a new test case. I also tested locally.

Screenshot 2023-03-13 at 20 45 13

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented Mar 13, 2023

Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit 2b7a13b
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/640f8e3a2e48d200084f40b5

@github-actions github-actions bot added A-Linter Area: linter A-LSP Area: language server protocol A-Project Area: project configuration and loading labels Mar 13, 2023
@ematipico ematipico force-pushed the feat/diagnostics-for-configuration branch 2 times, most recently from 8ceb498 to a4b2cd1 Compare March 13, 2023 20:55
@ematipico ematipico force-pushed the feat/diagnostics-for-configuration branch from a4b2cd1 to 2b7a13b Compare March 13, 2023 20:57
@ematipico ematipico merged commit af991f4 into main Mar 14, 2023
@ematipico ematipico deleted the feat/diagnostics-for-configuration branch March 14, 2023 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter A-LSP Area: language server protocol A-Project Area: project configuration and loading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant