Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

refactor(rome_js_analyze): add more tests and docs for a11y rules through refactoring #4417

Merged
merged 13 commits into from
Apr 30, 2023

Conversation

nissy-dev
Copy link
Contributor

Summary

I added more tests and docs for a11y rules through refactoring based on #4342

Test Plan

This is internal refactoring, so I don't update the CHAGELOG.md

Changelog

  • The PR requires a changelog line

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented Apr 28, 2023

Deploy Preview for docs-rometools failed.

Name Link
🔨 Latest commit 64fa619
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/644dfed1202804000871e044

@github-actions github-actions bot added A-Linter Area: linter A-Parser Area: parser A-Project Area: project configuration and loading labels Apr 28, 2023
@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 48863 48863 0
Passed 47796 47796 0
Failed 1067 1067 0
Panics 0 0 0
Coverage 97.82% 97.82% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6212 6212 0
Passed 1763 1763 0
Failed 4449 4449 0
Panics 0 0 0
Coverage 28.38% 28.38% 0.00%

ts/babel

Test result main count This PR count Difference
Total 639 639 0
Passed 573 573 0
Failed 66 66 0
Panics 0 0 0
Coverage 89.67% 89.67% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17224 17224 0
Passed 13122 13122 0
Failed 4102 4102 0
Panics 0 0 0
Coverage 76.18% 76.18% 0.00%

@nissy-dev nissy-dev marked this pull request as ready for review April 28, 2023 07:34
@ematipico ematipico merged commit d3ed917 into main Apr 30, 2023
@ematipico ematipico deleted the refactor/lint-rules-2 branch April 30, 2023 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter A-Parser Area: parser A-Project Area: project configuration and loading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants