Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_analyze): #4410 #4418

Merged
merged 1 commit into from
Apr 28, 2023
Merged

fix(rome_js_analyze): #4410 #4418

merged 1 commit into from
Apr 28, 2023

Conversation

Conaclos
Copy link
Contributor

@Conaclos Conaclos commented Apr 28, 2023

Summary

Fix #4410 and make the rule more robust by handling more cases such as:

<button type/>

I also made some refactoring to simplify the implementation.

Test Plan

New tests and regression tests included.

Changelog

  • The PR requires a changelog line

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented Apr 28, 2023

Deploy Preview for docs-rometools failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 58fb612
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/644bf10c0d9f450008696b12

@github-actions github-actions bot added the A-Linter Area: linter label Apr 28, 2023
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Rule caught some cases in our playground that we should fix :D

@Conaclos Conaclos merged commit 5aa3efa into rome:main Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 lint/a11y/useButtonType misses some issues
3 participants