This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 657
fix(rome_js_semantic): correct the export determination when a variable and an interface
had the same name
#4468
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0f477f1
fix: correct the export determination caused by ts interface
unvalley 4e37b09
chore: CHANGELOG.md
unvalley 7e73b71
chore: typo
unvalley 1f6a472
chore: add other changes to linter section
unvalley c1c1d53
refactor: updated property and added comment for DecalredBinding struct
unvalley 85d6300
refactor: renamed to BiningInfo and added comment
unvalley c80655b
chore: add more comments
unvalley ce2deaa
refactor: comments
unvalley 8f7bea2
Merge branch 'main' into fix-4353
unvalley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
...rome_js_analyze/tests/specs/correctness/noUnusedVariables/validClassAndInterfaceExport.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
/* should not generate diagnostics */ | ||
class A {} | ||
|
||
interface A { | ||
foo: string; | ||
} | ||
|
||
export { A }; |
18 changes: 18 additions & 0 deletions
18
...js_analyze/tests/specs/correctness/noUnusedVariables/validClassAndInterfaceExport.ts.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
--- | ||
source: crates/rome_js_analyze/tests/spec_tests.rs | ||
expression: validClassAndInterfaceExport.ts | ||
--- | ||
# Input | ||
```js | ||
/* should not generate diagnostics */ | ||
class A {} | ||
|
||
interface A { | ||
foo: string; | ||
} | ||
|
||
export { A }; | ||
|
||
``` | ||
|
||
|
8 changes: 8 additions & 0 deletions
8
crates/rome_js_analyze/tests/specs/correctness/noUnusedVariables/validVariableAndExport.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
/* should not generate diagnostics */ | ||
const a = ""; | ||
|
||
interface a { | ||
foo: string; | ||
} | ||
|
||
export { a }; |
18 changes: 18 additions & 0 deletions
18
.../rome_js_analyze/tests/specs/correctness/noUnusedVariables/validVariableAndExport.ts.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
--- | ||
source: crates/rome_js_analyze/tests/spec_tests.rs | ||
expression: validVariableAndExport.ts | ||
--- | ||
# Input | ||
```js | ||
/* should not generate diagnostics */ | ||
const a = ""; | ||
|
||
interface a { | ||
foo: string; | ||
} | ||
|
||
export { a }; | ||
|
||
``` | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add the
#### Other changes
heading