-
Notifications
You must be signed in to change notification settings - Fork 659
Conversation
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
crates/rome_js_analyze/src/analyzers/complexity/no_useless_type_constraint.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_useless_type_constraint.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_useless_type_constraint.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_useless_type_constraint.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_useless_type_constraint.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
crates/rome_js_analyze/src/analyzers/complexity/no_useless_type_constraint.rs
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_useless_type_constraint.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/complexity/no_useless_type_constraint.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Victorien ELVINGER <victorien@elvinger.fr>
Thank you for your time! I tried to address the stuff in the review. This PR should probably be squashed if it will be merged. |
No worry, we always squash the PRs :) By the way, could you rebase on main in order to resolve the conflicts? |
Done (+ resolve formatting issues) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
There are still some errors: it seems you have to run just |
Summary
I'm relatively novel to rust and the rome internals. Please don't hesitate to state enhancements. I'd like to learn. :)
Also, feel free to push directly into my repository and/or close this PR if it doesn't fit.
Resolves #4480
Test Plan
Uset test:
Changelog
Documentation
(in case that an update is needed, please comment)