This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 659
chore: Resolve set-output
deprecations
#4507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
ematipico
reviewed
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this! Just a small comment left
The code is pretty old, we can just pipe it into a file instead https://github.com/Boshen/oxc/blob/9678832f2b1124c118d33ab48ad984c9906da9a0/.github/workflows/benchmark.yml#L121 |
CI gives this warning: ``` The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. ``` Migration guide is located here: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
nikeee
force-pushed
the
enhancement/migrate-set-output
branch
from
May 18, 2023 18:11
cd0a866
to
309f3c7
Compare
!bench_parser |
Parser Benchmark Results
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CI gives this warning:
Migration guide is located here:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Changelog
Documentation