fix(rome_service): treat nursery rules differently

[ematipico]

Summary

Closes #4479

We treat nursery rules differently from the rest of the rules. We treated them differently only when using the top recommended: true but not when nursery: {} was defined.

This PR changes the code generation of the configuration to enable recommended rules only when recommended: true.

Test Plan

Added the test case of the issue

Changelog

• The PR requires a changelog line

Documentation

• The PR requires documentation
• I will create a new PR to update the documentation

[netlify]

✅ Deploy Preview for docs-rometools ready!

Name	Link
🔨 Latest commit	0313b47
🔍 Latest deploy log	https://app.netlify.com/sites/docs-rometools/deploys/64673d9bcfb9e500079a1259
😎 Deploy Preview	https://deploy-preview-4511--docs-rometools.netlify.app/playground
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[ematipico]

cc @Vivalldi

[github-actions]

Parser conformance results on ubuntu-latest

js/262

Test result	main count	This PR count	Difference
Total	48863	48863	0
Passed	47796	47796	0
Failed	1067	1067	0
Panics	0	0	0
Coverage	97.82%	97.82%	0.00%

jsx/babel

Test result	main count	This PR count	Difference
Total	40	40	0
Passed	37	37	0
Failed	3	3	0
Panics	0	0	0
Coverage	92.50%	92.50%	0.00%

symbols/microsoft

Test result	main count	This PR count	Difference
Total	6212	6212	0
Passed	1763	1763	0
Failed	4449	4449	0
Panics	0	0	0
Coverage	28.38%	28.38%	0.00%

ts/babel

Test result	main count	This PR count	Difference
Total	639	639	0
Passed	573	573	0
Failed	66	66	0
Panics	0	0	0
Coverage	89.67%	89.67%	0.00%

ts/microsoft

Test result	main count	This PR count	Difference
Total	17224	17224	0
Passed	13127	13127	0
Failed	4097	4097	0
Panics	0	0	0
Coverage	76.21%	76.21%	0.00%

[Conaclos]

Should we also update how we handle all? I don't think so, as the intention of all is to enable all rules, including nursery rules. However, this looks a bit inconsistent and complex. A user might expect all to behave like recommended, i.e. affecting only stable (non-nursery) rules.

I am still not a fan of the current configuration shape: too much nesting and a bit complex for my taste. I already suggested this: I might prefer a flag to enable/disable the application of recommended andall to nursery rules. Something like experimental.

In my opinion, [group], recommended, all should be tags on rules.
The default configuration could be something like { recommended: true, nursery: false }. Note that here we don't need experimental since nursery is a group/tag.
Rules could be listed directly in `rules'. This also avoids the need to update the config when a nursery rule is promoted.

[ematipico]

True. all should not change its behaviour for now.

You might be onto something, although I don't understand yet how you would want to change the configuration.

If you want , feel free to open a discussion with your proposal :)

[Vivalldi]

I appreciate all the work you've done to get this in 🙇🏻

[Vivalldi]

A drawback to this test is it relies on one of these 3 rules to be in the nursery still

lint/nursery/noBannedTypes
lint/nursery/noConstantCondition
lint/nursery/useLiteralKeys

Are there any nursery rules that only exist at test time?

[ematipico]

Unfortunately no. That's the bad thing of this test :(

When we promote the rules, it's going to fail, probably. But I think it's okay.