fix(rome_js_analyze): noRedeclare accepts index signatures

[unvalley]

Summary

Closes #4478 #4545

Test Plan

cargo test -p rome_js_analyze -- no_redeclare

Handle these test cases:

// valid
type ValidIndexSignatures = {
	a: {
		[index: string]: string;
	};
	b: {
		[index: string]: string;
	};
};

// valid
interface A { [index: string]: string; [index: number]: string; }

// invalid
interface A { [index: number]: string; [index: number]: string; }

// valid #4545
let a: { [key: string]: string };
let b: { [key: string]: string };

Changelog

• The PR requires a changelog line

Documentation

• The PR requires documentation
• I will create a new PR to update the documentation

[netlify]

✅ Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	029c4a2
🔍 Latest deploy log	https://app.netlify.com/sites/docs-rometools/deploys/6487086b1954790008f9cbe1
😎 Deploy Preview	https://deploy-preview-4519--docs-rometools.netlify.app/playground
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[Vivalldi]

Anything we can do to help get this out of draft?

[unvalley]

@Vivalldi

I need to accept the case below while fixing the problem. current implementation is not enough.

type IndexSignatures = {
    [index: number]: string,
    [index: string]: string
}

[unvalley]

I want to check if we have the same parent TsTypeMember.
Other than using text_range, is there any other way to check that they are defined with the same parent (same location)?

[denbezrukov]

Can we compare their parent nodes?

    let first_parent = first
        .parent::<TsTypeMemberList>()?;

    let second_parent = second
        .parent::<TsTypeMemberList>()?;
    Some(first_parent == second_parent)

[ematipico]

Indeed. We should be able to plainly compare two nodes using ==

[unvalley]

Thanks, I refactored.

[ematipico]

Looks good to me!