Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_analyze): suppress false positive when returning call expressions of a hook for useHookAtTopLevel #4538

Merged
merged 4 commits into from
May 31, 2023

Conversation

nissy-dev
Copy link
Contributor

Summary

Fix #4483

Test Plan

I added some snapshot tests.

Changelog

  • The PR requires a changelog line

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented May 28, 2023

Deploy Preview for docs-rometools ready!

Name Link
🔨 Latest commit fc432c6
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64778071f13461000852c4d2
😎 Deploy Preview https://deploy-preview-4538--docs-rometools.netlify.app/playground
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the A-Linter Area: linter label May 28, 2023
@ematipico
Copy link
Contributor

Happy to merge once the conflicts are solved :)

@nissy-dev
Copy link
Contributor Author

Thank you for your reviews!

@nissy-dev nissy-dev merged commit 665bb9d into main May 31, 2023
@nissy-dev nissy-dev deleted the fix-false-positive-useHookAtTopLevel branch May 31, 2023 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Returning the return value of a hook triggers false positive for useHookAtTopLevel
2 participants