This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_service): add support for JSON linter in the workspace #4609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
github-actions
bot
added
A-CLI
Conaclos
approved these changes
Jun 26, 2023
ematipico
force-pushed
the
feat/workspace-lint-json
branch
from
e433c07
to
26e22b3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4444
As for now I just limited myself to implement the
lintfunction because we don't have actions for JSON lint rules.Test Plan
Added a new test case to make sure we get diagnostics.
Changelog
Documentation