Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): noGlobalIsNan #4612

Merged
merged 1 commit into from
Jun 24, 2023
Merged

feat(rome_js_analyze): noGlobalIsNan #4612

merged 1 commit into from
Jun 24, 2023

Conversation

Conaclos
Copy link
Contributor

@Conaclos Conaclos commented Jun 24, 2023

Summary

This rule recommends using Number.isNaN instead of the global and unsafe isNaN that attempts a coercion.

Test Plan

Tests included.

@netlify
Copy link

netlify bot commented Jun 24, 2023

Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 68e60b5
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/649742b5a7195300089b9985
😎 Deploy Preview https://deploy-preview-4612--docs-rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Conaclos Conaclos requested a review from ematipico June 24, 2023 13:24
@github-actions github-actions bot added A-Diagnostic Area: errors and diagnostics A-Linter Area: linter A-Project Area: project configuration and loading labels Jun 24, 2023
@Conaclos Conaclos requested a review from ematipico June 24, 2023 16:36
@Conaclos Conaclos merged commit e2ffdf6 into rome:main Jun 24, 2023
@Conaclos Conaclos deleted the noGlobalIsNaN branch June 25, 2023 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Diagnostic Area: errors and diagnostics A-Linter Area: linter A-Project Area: project configuration and loading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants