This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): add noGlobalIsFinite #4613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
github-actions
bot
added
A-Diagnostic
ematipico
approved these changes
Jun 25, 2023
crates/rome_js_analyze/tests/specs/nursery/noGlobalIsFinite/invalid.js.snap
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This rule recommends using
Number.isFiniteinstead of the global and unsafeisFinitethat attempts a type coercion.I was wondering if this could not be merged with
noGlobalIsNan. However, I didn't find a common name... This is why I proposed two distinct rules.Test Plan
Tests included.