Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_analyze): suppress useHookAtTopLevel's false positive when accessing properties directly from a hook #4645

Merged
merged 2 commits into from
Jul 2, 2023
Merged

fix(rome_js_analyze): suppress useHookAtTopLevel's false positive when accessing properties directly from a hook #4645

merged 2 commits into from
Jul 2, 2023

Conversation

nissy-dev
Copy link
Contributor

Summary

Fix #4637

Test Plan

I added some snapshot tests

@netlify
Copy link

netlify bot commented Jul 2, 2023 •
edited
Loading

✅ Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit bddb717
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64a1054f3e888400088c54a5

@github-actions github-actions bot added the A-Linter Area: linter label Jul 2, 2023
ematipico
ematipico approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is another great fix. Thank you, @nissy-dev !

@ematipico ematipico merged commit 60ee106 into main Jul 2, 2023
@ematipico ematipico deleted the fix-false-positive-use_hook_at_top_level branch July 2, 2023 11:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-Linter Area: linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 nursery/useHookAtTopLevel false positive when accessing properties directly from a hook
2 participants
@nissy-dev @ematipico