This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): noUselessFragments use JsxString node when replacing JsxText #4662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
Conaclos
approved these changes
Jul 6, 2023
|
@Conaclos Thank you for your review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #4639
see: https://docs.rome.tools/playground/?lintRules=all&code=ZQB4AHAAbwByAHQAIABmAHUAbgBjAHQAaQBvAG4AIABTAG8AbQBlAEMAbwBtAHAAbwBuAGUAbgB0ACgAKQAgAHsACgAgACAAcgBlAHQAdQByAG4AIAA8AGQAaQB2ACAAeAAtAHMAbwBtAGUALQBwAHIAbwBwAD0AewA8AD4ARgBvAG8APAAvAD4AfQAgAC8APgA7AAoAfQAKAAoAZQB4AHAAbwByAHQAIABmAHUAbgBjAHQAaQBvAG4AIABTAG8AbQBlAEMAbwBtAHAAbwBuAGUAbgB0AEEAKAApACAAewAKACAAIAByAGUAdAB1AHIAbgAgADwAZABpAHYAIAB4AC0AcwBvAG0AZQAtAHAAcgBvAHAAPQAiAEYAbwBvACIAIAAvAD4AOwAKAH0A
Test Plan
I update some snapshot tests and I checked the issue was resolved by using https://github.com/fubhy/rome-bug-repro.