This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): useLiteralKeys handle string literal properties
#4692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
github-actions
bot
added
A-Linter
ematipico
approved these changes
Jul 13, 2023
I am not sure what you refer to, so I just add a note to be sure: template string properties are not syntactically valid in js: const a = {
`prop`: 0, // syntax error
} |
|
Oh, it's already handled. Could you be more precise in the changelog, then? It should phrase "string literal properties inside interfaces and objects" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #4690
Test Plan
New test included.