Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat: 🎸 allow comments in json file #4714

Merged
merged 19 commits into from
Jul 20, 2023
Merged

feat: 🎸 allow comments in json file #4714

merged 19 commits into from
Jul 20, 2023

Conversation

ematipico
Copy link
Contributor

@ematipico ematipico commented Jul 20, 2023

Summary

I picked up #4382 and finished it. Although, this does implement only the parsing. As you might notice, the formatting part still needs to be completed.

As for now, allow_comments inside the workspace is always false to avoid regressions.

Test Plan

Probably added. If not, I will add them later.

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit a8b520d
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64b907f111951e00087dcd68

@github-actions github-actions bot added A-Formatter Area: formatter A-CLI Area: CLI A-Parser Area: parser A-Tooling Area: our own build, development, and release tooling A-Project Area: project configuration and loading labels Jul 20, 2023
@github-actions github-actions bot added the A-Linter Area: linter label Jul 20, 2023
@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 48863 48863 0
Passed 47810 47810 0
Failed 1053 1053 0
Panics 0 0 0
Coverage 97.84% 97.84% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6212 6212 0
Passed 1764 1764 0
Failed 4448 4448 0
Panics 0 0 0
Coverage 28.40% 28.40% 0.00%

ts/babel

Test result main count This PR count Difference
Total 639 639 0
Passed 573 573 0
Failed 66 66 0
Panics 0 0 0
Coverage 89.67% 89.67% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17224 17224 0
Passed 13121 13121 0
Failed 4103 4103 0
Panics 0 0 0
Coverage 76.18% 76.18% 0.00%

@ematipico ematipico marked this pull request as ready for review July 20, 2023 09:16
Copy link
Contributor

@denbezrukov denbezrukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🥳

@ematipico ematipico merged commit 4795727 into main Jul 20, 2023
18 checks passed
@ematipico ematipico deleted the feat/json-comments branch July 20, 2023 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-CLI Area: CLI A-Formatter Area: formatter A-Linter Area: linter A-Parser Area: parser A-Project Area: project configuration and loading A-Tooling Area: our own build, development, and release tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants