Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): noUnsafeDeclarationMerging #4736

Merged
merged 2 commits into from
Jul 29, 2023
Merged

feat(rome_js_analyze): noUnsafeDeclarationMerging #4736

merged 2 commits into from
Jul 29, 2023

Conversation

Conaclos
Copy link
Contributor

Summary

Implements no-unsafe-declaration-merging with a minor difference: we accept declaration merging between an interface and an ambient class because it is not unsafe.

Test Plan

ESlint tests included and extra tests.

@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit f5220d8
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64c443bd69c5d800081fd390

@github-actions github-actions bot added A-Website Area: website and documentation A-Linter Area: linter L-JavaScript Langauge: JavaScript A-Project Area: project configuration and loading A-Diagnostic Area: errors and diagnostics labels Jul 28, 2023
@Conaclos Conaclos requested a review from ematipico July 28, 2023 21:47
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a weird rule :D let's ship it!

@Conaclos Conaclos merged commit f13de15 into rome:main Jul 29, 2023
17 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Diagnostic Area: errors and diagnostics A-Linter Area: linter A-Project Area: project configuration and loading A-Website Area: website and documentation L-JavaScript Langauge: JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants