Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): useGetterReturn #4760

Closed
wants to merge 1 commit into from
Closed

feat(rome_js_analyze): useGetterReturn #4760

wants to merge 1 commit into from

Conversation

Conaclos
Copy link
Contributor

@Conaclos Conaclos commented Aug 8, 2023

Summary

This implements getter-return.
We don't support the option allowImplicit (disabled by default).

In contrast to the ESlint rule we do not report the dynamic cases such as:

Object.defineProperty(foo, 'bar', {
    get(){}
});

Test Plan

ESlint tests included and more complex cases (with exception handlers and loops).

@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit df91db5
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64d3b0231fd28f00074a51e3

@github-actions github-actions bot added A-Website Area: website and documentation A-Linter Area: linter L-JavaScript Langauge: JavaScript A-Project Area: project configuration and loading A-Diagnostic Area: errors and diagnostics labels Aug 8, 2023
@Conaclos Conaclos requested a review from nissy-dev August 8, 2023 20:53
@Conaclos Conaclos requested review from ematipico and removed request for nissy-dev August 9, 2023 12:16
Copy link
Contributor

@nissy-dev nissy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 The code is really helpful to fix false positive diagnostics noUnreachableSuper reported

@Conaclos Conaclos closed this Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Diagnostic Area: errors and diagnostics A-Linter Area: linter A-Project Area: project configuration and loading A-Website Area: website and documentation L-JavaScript Langauge: JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants