Fixes "bad floating point" problem with task-3.0.1 #2649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After upgrading TaskWarrior to 3.0.1, I think... the comand means to return some "Runnable" which resolves to a float, now returns the float itself. So when we try to resolve the Runnable, ZSH throws an exception, and p10k cannot parse the float from that. This just changes the assumption that we get a float back. p.s: Please when reviewing, ask youself "How does this affect P10K at large?" I don't have this purview, but this change sure fixes my problem. Fixes romkatv#2648
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading TaskWarrior to 3.0.1, I think... the comand means to
return some "Runnable" which resolves to a float, now returns the float
itself. So when we try to resolve the Runnable, ZSH throws an exception,
and p10k cannot parse the float from that. This just changes the
assumption that we get a float back.
p.s: Please when reviewing, ask youself "How does this affect P10K at
large?" I don't have this purview, but this change sure fixes my
problem.
Fixes #2648