Skip to content

Commit

Permalink
Merge pull request #1055 from rommapp/type-fix-additional-content
Browse files Browse the repository at this point in the history
Add workflow that runs typecheck on PRs
  • Loading branch information
gantoine authored Aug 5, 2024
2 parents 7e52b50 + ebe570d commit 9b4206a
Show file tree
Hide file tree
Showing 3 changed files with 41 additions and 9 deletions.
12 changes: 4 additions & 8 deletions .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,13 @@ name: Run Pytest

on:
pull_request:
paths-ignore:
- "docker/**"
- "examples/*"
- "frontend/**"
paths:
- "backend/**"
push:
branches:
- "master"
paths-ignore:
- "docker/**"
- "examples/*"
- "frontend/**"
paths:
- "backend/**"

permissions: read-all

Expand Down
36 changes: 36 additions & 0 deletions .github/workflows/typecheck.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
name: Run Typescript Typecheck

on:
pull_request:
paths:
- "frontend/**"
push:
branches:
- "master"
paths:
- "frontend/**"

permissions: read-all

jobs:
typecheck:
runs-on: ubuntu-latest
permissions:
checks: write
pull-requests: write
steps:
- name: Checkout repository
uses: actions/checkout@v3

- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: "18"

- name: Install dependencies
run: npm install
working-directory: frontend

- name: Run typecheck
run: npm run typecheck
working-directory: frontend
2 changes: 1 addition & 1 deletion frontend/src/components/Details/AdditionalContent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const combined = ref([
:href="`https://www.igdb.com/games/${expansion.slug}`"
target="_blank"
>
<related-card :rom="expansion" />
<related-card :game="expansion" />
</a>
</v-col>
</v-row>
Expand Down

0 comments on commit 9b4206a

Please sign in to comment.