Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make upload timeout configurable #1228

Closed
yuri-becker opened this issue Oct 7, 2024 · 3 comments
Closed

[Feature] Make upload timeout configurable #1228

yuri-becker opened this issue Oct 7, 2024 · 3 comments
Labels
feature New feature or request

Comments

@yuri-becker
Copy link

Is your feature request related to a problem? Please describe.
When uploading larger files to RomM, the upload is cancelled after exactly two minutes. When the instance is on a remote server, uploads of even DVD games can take far longer.

Describe the solution you'd like
Ideally, admins would be able to configure the timeout, or completely disabling it. Possibly via Environment Variables.

Describe alternatives you've considered
An alternative would be to just statically disable the timeout or set it to a high enough time.

Additional context
I originally commented this request on this commit: e20465f?diff=unified#diff-90fd36aad18db541451cbf233c961cb25c21a3f107ff47e0f8b89057c590797c
This also shows the relevant piece of code.

@yuri-becker yuri-becker added the feature New feature or request label Oct 7, 2024
@yuri-becker
Copy link
Author

I would also be willing to implement this myself if you're open to it.

@gantoine
Copy link
Member

gantoine commented Oct 10, 2024

Yeah go for it! You'll want to add an env variable for it and import it in config/__init__.py (like we do for SCAN_TIMEOUT). just make sure the default stays the same 600 seconds/10 mins.

gantoine added a commit that referenced this issue Oct 14, 2024
@gantoine
Copy link
Member

Closing this as its merged, will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants