-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Multifiles download not downloading only eating server RAM #332
Comments
I've seen this as well, and AFAICT it's due to python's inability to stream ZIP data. The fact that it keeps eating up memory is weird, but there are a couple solutions around this that I'd like to try. |
Thank you for pointing it out. I never tried with something bigger than 1GB and didn't noticed. |
Right now the downloader should be very much consistent thanks to @gantoine! |
@Smurre95 Are you using the latest version of master to test it (like building you own image)? If so, can you try downloading multiple multi-file games at the same time, and let me know how it behaves? |
I tested it and it works so smooth, but would be nice if @Smurre95 could test it. |
RomM version
Version of RomM you are using
1.9.1
Describe the bug
A clear and concise description of what the bug is.
When trying to download files that is a multi file selection i don't see any way that the download i starting or even starts creating a zip file. But in my main system i see the docker eating more and more ram. This is for any size of multi file selection. Once i let it be for about 30 min and it had almost all of my 40 GB of server ram allocated to it and still no download completed to my system. Dose not matter the size of the files. Tested with a Gamecube dual disc game so that would be about 3GB in total.
To Reproduce
Steps to reproduce the behavior:
Download more than one file form the same game
Expected behavior
To create a zip and then start the download
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Firefox
Version 116.0.2 (64-bit)
And
Edge
Version 115.0.1901.200 (Official build) (64-bit
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: