Fix multi rom zipping + streaming #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to test this with proper big files. Once tested I merge it! |
zurdi15
approved these changes
Aug 11, 2023
zurdi15
added a commit
that referenced
this pull request
Aug 27, 2023
Fix multi rom zipping + streaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches multi-rom zipping to use the stream-zip library. Instead of having to write the entirety of the zip to a temp file then load it into memory, stream-zip allows us to stream 64KB chunks as the zip file generates.
Note: I chose to compress with zip64 since some files may be over zip32's 4GB/file limit. There are some limitations to zip64 support, most notably Safari's auto-extract behaviour. Zip64 is natively supported on most modern OSs.
Fixes #332