Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filter Switch titledb entries with empty id #1006

Merged

Conversation

adamantike
Copy link
Collaborator

The existing code was failing after changes on the upstream JSON file that included entries with null ID.

The existing code was failing after changes on the upstream JSON file
that included entries with `null` ID.
@adamantike adamantike force-pushed the fix/handle-switch-titledb-empty-product-id branch from b873663 to 04b64f1 Compare July 18, 2024 14:00
Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 💯

btw you can change your upstream to point to this repo now that you have push access!

@gantoine gantoine merged commit 3073e16 into rommapp:master Jul 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants