-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: Replace pytest-vcr dependency with pytest-recording #1021
misc: Replace pytest-vcr dependency with pytest-recording #1021
Conversation
`pytest-vcr` [1] is no longer maintained (last commit was in 2020), and `VCR.py` recommends [2] `pytest-recording` instead. Also, `pytest-vcr` does not correctly support `httpx` [3]. This change also removes unused cassettes. [1] https://github.com/ktosiek/pytest-vcr [2] https://vcrpy.readthedocs.io/en/latest/usage.html#pytest-integration [3] ktosiek/pytest-vcr#46
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah so it's a drop-in replacement, and you can still mark tests with @pytest.mark.vcr
?
Exactly, decorator is the same, but this diff became huge as we had many legacy cassettes that weren't being used. |
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [rommapp/romm](https://github.com/rommapp/romm) | minor | `3.3.0` -> `3.4.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>rommapp/romm (rommapp/romm)</summary> ### [`v3.4.0`](https://github.com/rommapp/romm/releases/tag/3.4.0) [Compare Source](https://github.com/rommapp/romm/compare/3.3.0...3.4.0) #### What's Changed - feat: Added link to home button by [@​zurdi15](https://github.com/zurdi15) in [https://github.com/rommapp/romm/pull/1054](https://github.com/rommapp/romm/pull/1054) - feat: Public collections by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/1028](https://github.com/rommapp/romm/pull/1028) - feat: Added aditional platform icons by [@​Casuallynoted](https://github.com/Casuallynoted) in [https://github.com/rommapp/romm/pull/1038](https://github.com/rommapp/romm/pull/1038) - feat: Store and re-use last saved bios/save/state/core by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/1037](https://github.com/rommapp/romm/pull/1037) - feat: Clickable filter buttons on details view by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/1040](https://github.com/rommapp/romm/pull/1040) - feat: Add button to show duplicates by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/1043](https://github.com/rommapp/romm/pull/1043) - fix: Scanning selected roms by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/1042](https://github.com/rommapp/romm/pull/1042) - fix: Use namespaced cookie for session by [@​adamantike](https://github.com/adamantike) in [https://github.com/rommapp/romm/pull/1009](https://github.com/rommapp/romm/pull/1009) - fix: Replace game-and-watch with g-and-w by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/1026](https://github.com/rommapp/romm/pull/1026) - fix: Backend URL redirection logic by [@​adamantike](https://github.com/adamantike) in [https://github.com/rommapp/romm/pull/1058](https://github.com/rommapp/romm/pull/1058) - fix: Enable flake8-async rules in ruff and fix warnings by [@​adamantike](https://github.com/adamantike) in [https://github.com/rommapp/romm/pull/1030](https://github.com/rommapp/romm/pull/1030) - fix: Initialize context on scheduled task by [@​adamantike](https://github.com/adamantike) in [https://github.com/rommapp/romm/pull/1033](https://github.com/rommapp/romm/pull/1033) - fix: Return early if IGDB finds an exact match by [@​adamantike](https://github.com/adamantike) in [https://github.com/rommapp/romm/pull/1032](https://github.com/rommapp/romm/pull/1032) - fix: CSRF token issues by [@​zurdi15](https://github.com/zurdi15) in [https://github.com/rommapp/romm/pull/1057](https://github.com/rommapp/romm/pull/1057) - fix: Link from related games by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/1045](https://github.com/rommapp/romm/pull/1045) - fix: Typos in frontend by [@​HellLord77](https://github.com/HellLord77) in [https://github.com/rommapp/romm/pull/1048](https://github.com/rommapp/romm/pull/1048) - fix: Firmware pagination by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/1041](https://github.com/rommapp/romm/pull/1041) - fix: Multi-file download in gallery view by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/1044](https://github.com/rommapp/romm/pull/1044) - fix: Remove persistent overlay prevents back navigation by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/1036](https://github.com/rommapp/romm/pull/1036) - misc: Add Redis async cache by [@​adamantike](https://github.com/adamantike) in [https://github.com/rommapp/romm/pull/1010](https://github.com/rommapp/romm/pull/1010) - misc: Create config.batocera-retrobat.yml by [@​TyroneSlothrop](https://github.com/TyroneSlothrop) in [https://github.com/rommapp/romm/pull/1013](https://github.com/rommapp/romm/pull/1013) - misc: Migrate MobyGamesHandler to async by [@​adamantike](https://github.com/adamantike) in [https://github.com/rommapp/romm/pull/1011](https://github.com/rommapp/romm/pull/1011) - misc: Migrate filesystem resource handler to async by [@​adamantike](https://github.com/adamantike) in [https://github.com/rommapp/romm/pull/1017](https://github.com/rommapp/romm/pull/1017) - misc: Replace pytest-vcr dependency with pytest-recording by [@​adamantike](https://github.com/adamantike) in [https://github.com/rommapp/romm/pull/1021](https://github.com/rommapp/romm/pull/1021) - misc: Refactor scan process by splitting single function by [@​adamantike](https://github.com/adamantike) in [https://github.com/rommapp/romm/pull/1024](https://github.com/rommapp/romm/pull/1024) - misc: Migrate IGDBBaseHandler to async by [@​adamantike](https://github.com/adamantike) in [https://github.com/rommapp/romm/pull/1023](https://github.com/rommapp/romm/pull/1023) - misc: Use PYTEST_VERSION variable to detect Pytest runs by [@​adamantike](https://github.com/adamantike) in [https://github.com/rommapp/romm/pull/1034](https://github.com/rommapp/romm/pull/1034) - misc: Use async interface for stream-zip by [@​adamantike](https://github.com/adamantike) in [https://github.com/rommapp/romm/pull/1035](https://github.com/rommapp/romm/pull/1035) - misc: Add workflow that runs typecheck on PRs by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/1055](https://github.com/rommapp/romm/pull/1055) - misc: Make backend handle URLs with trailing slash by [@​adamantike](https://github.com/adamantike) in [https://github.com/rommapp/romm/pull/1059](https://github.com/rommapp/romm/pull/1059) - misc: Drop ROMM_AUTH_USERNAME and ROMM_AUTH_PASSWORD env variables by [@​gantoine](https://github.com/gantoine) in [https://github.com/rommapp/romm/pull/1060](https://github.com/rommapp/romm/pull/1060) #### New Contributors - [@​TyroneSlothrop](https://github.com/TyroneSlothrop) made their first contribution in [https://github.com/rommapp/romm/pull/1013](https://github.com/rommapp/romm/pull/1013) **Full Changelog**: rommapp/romm@3.3.0...3.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMS4zIiwidXBkYXRlZEluVmVyIjoiMzguMjEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvY29udGFpbmVyIiwidHlwZS9taW5vciJdfQ==-->
pytest-vcr
[1] is no longer maintained (last commit was in 2020), andVCR.py
recommends [2]pytest-recording
instead.Also,
pytest-vcr
does not correctly supporthttpx
[3].This change also removes unused cassettes.
[1] https://github.com/ktosiek/pytest-vcr
[2] https://vcrpy.readthedocs.io/en/latest/usage.html#pytest-integration
[3] ktosiek/pytest-vcr#46