Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROMM-1022] Add button to show duplicates #1043

Merged
merged 3 commits into from
Aug 4, 2024
Merged

[ROMM-1022] Add button to show duplicates #1043

merged 3 commits into from
Aug 4, 2024

Conversation

gantoine
Copy link
Member

Add a button to only display duplicate games (even then grouped). This could be handy for finding games that were marked as duplicate, but are actually different games (like different IGDB/Moby IDs). Eventually this should also toss hashes into the mix, once that work is complete.

Fixes #1022

Screenshot 2024-07-28 at 8 30 51 PM

@gantoine gantoine requested a review from adamantike July 29, 2024 00:32
@gantoine gantoine changed the title Add button to show duplicates [ROMM-1022] Add button to show duplicates Jul 29, 2024
Copy link

github-actions bot commented Aug 2, 2024

Test Results

72 tests   72 ✅  21s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit c77ca88.

♻️ This comment has been updated with latest results.

@@ -31,7 +31,7 @@ function setFavourites() {
'text-romm-white': !filterFavourites,
'text-romm-accent-1': filterFavourites,
}"
>Filter favourites</span
>Show favourites</span
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gantoine gantoine merged commit b06b0f4 into master Aug 4, 2024
8 checks passed
@gantoine gantoine deleted the romm-1022 branch August 4, 2024 20:15
@zurdi15 zurdi15 mentioned this pull request Aug 7, 2024
spiceratops referenced this pull request in spiceratops/k8s-gitops Aug 20, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [rommapp/romm](https://github.com/rommapp/romm) | minor | `3.3.0` ->
`3.4.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>rommapp/romm (rommapp/romm)</summary>

### [`v3.4.0`](https://github.com/rommapp/romm/releases/tag/3.4.0)

[Compare
Source](https://github.com/rommapp/romm/compare/3.3.0...3.4.0)

#### What's Changed

- feat: Added link to home button by
[@&#8203;zurdi15](https://github.com/zurdi15) in
[https://github.com/rommapp/romm/pull/1054](https://github.com/rommapp/romm/pull/1054)
- feat: Public collections by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1028](https://github.com/rommapp/romm/pull/1028)
- feat: Added aditional platform icons by
[@&#8203;Casuallynoted](https://github.com/Casuallynoted) in
[https://github.com/rommapp/romm/pull/1038](https://github.com/rommapp/romm/pull/1038)
- feat: Store and re-use last saved bios/save/state/core by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1037](https://github.com/rommapp/romm/pull/1037)
- feat: Clickable filter buttons on details view by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1040](https://github.com/rommapp/romm/pull/1040)
- feat: Add button to show duplicates by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1043](https://github.com/rommapp/romm/pull/1043)
- fix: Scanning selected roms by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1042](https://github.com/rommapp/romm/pull/1042)
- fix: Use namespaced cookie for session by
[@&#8203;adamantike](https://github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1009](https://github.com/rommapp/romm/pull/1009)
- fix: Replace game-and-watch with g-and-w by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1026](https://github.com/rommapp/romm/pull/1026)
- fix: Backend URL redirection logic by
[@&#8203;adamantike](https://github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1058](https://github.com/rommapp/romm/pull/1058)
- fix: Enable flake8-async rules in ruff and fix warnings by
[@&#8203;adamantike](https://github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1030](https://github.com/rommapp/romm/pull/1030)
- fix: Initialize context on scheduled task by
[@&#8203;adamantike](https://github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1033](https://github.com/rommapp/romm/pull/1033)
- fix: Return early if IGDB finds an exact match by
[@&#8203;adamantike](https://github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1032](https://github.com/rommapp/romm/pull/1032)
- fix: CSRF token issues by
[@&#8203;zurdi15](https://github.com/zurdi15) in
[https://github.com/rommapp/romm/pull/1057](https://github.com/rommapp/romm/pull/1057)
- fix: Link from related games by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1045](https://github.com/rommapp/romm/pull/1045)
- fix: Typos in frontend by
[@&#8203;HellLord77](https://github.com/HellLord77) in
[https://github.com/rommapp/romm/pull/1048](https://github.com/rommapp/romm/pull/1048)
- fix: Firmware pagination by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1041](https://github.com/rommapp/romm/pull/1041)
- fix: Multi-file download in gallery view by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1044](https://github.com/rommapp/romm/pull/1044)
- fix: Remove persistent overlay prevents back navigation by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1036](https://github.com/rommapp/romm/pull/1036)
- misc: Add Redis async cache by
[@&#8203;adamantike](https://github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1010](https://github.com/rommapp/romm/pull/1010)
- misc: Create config.batocera-retrobat.yml by
[@&#8203;TyroneSlothrop](https://github.com/TyroneSlothrop) in
[https://github.com/rommapp/romm/pull/1013](https://github.com/rommapp/romm/pull/1013)
- misc: Migrate MobyGamesHandler to async by
[@&#8203;adamantike](https://github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1011](https://github.com/rommapp/romm/pull/1011)
- misc: Migrate filesystem resource handler to async by
[@&#8203;adamantike](https://github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1017](https://github.com/rommapp/romm/pull/1017)
- misc: Replace pytest-vcr dependency with pytest-recording by
[@&#8203;adamantike](https://github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1021](https://github.com/rommapp/romm/pull/1021)
- misc: Refactor scan process by splitting single function by
[@&#8203;adamantike](https://github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1024](https://github.com/rommapp/romm/pull/1024)
- misc: Migrate IGDBBaseHandler to async by
[@&#8203;adamantike](https://github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1023](https://github.com/rommapp/romm/pull/1023)
- misc: Use PYTEST_VERSION variable to detect Pytest runs by
[@&#8203;adamantike](https://github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1034](https://github.com/rommapp/romm/pull/1034)
- misc: Use async interface for stream-zip by
[@&#8203;adamantike](https://github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1035](https://github.com/rommapp/romm/pull/1035)
- misc: Add workflow that runs typecheck on PRs by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1055](https://github.com/rommapp/romm/pull/1055)
- misc: Make backend handle URLs with trailing slash by
[@&#8203;adamantike](https://github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1059](https://github.com/rommapp/romm/pull/1059)
- misc: Drop ROMM_AUTH_USERNAME and ROMM_AUTH_PASSWORD env variables by
[@&#8203;gantoine](https://github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1060](https://github.com/rommapp/romm/pull/1060)

#### New Contributors

- [@&#8203;TyroneSlothrop](https://github.com/TyroneSlothrop) made
their first contribution in
[https://github.com/rommapp/romm/pull/1013](https://github.com/rommapp/romm/pull/1013)

**Full Changelog**:
rommapp/romm@3.3.0...3.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMS4zIiwidXBkYXRlZEluVmVyIjoiMzguMjEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvY29udGFpbmVyIiwidHlwZS9taW5vciJdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants