fix: Avoid image requests for undefined.ico platform icon #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a platform slog is not present in `PLATFORMS_VERSIONS`, which is the common case overall, the component was trying to fetch an `undefined.ico` image. Instead of that, we should check if the platform slug is present in `PLATFORMS_VERSIONS` and if not, fallback to the platform slug itself.
gantoine
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a platform slug is not present in
PLATFORMS_VERSIONS, which is the common case overall, the component was trying to fetch anundefined.icoimage.Instead of that, we should check if the platform slug is present in
PLATFORMS_VERSIONSand if not, fallback to the platform slug itself.